Skip to content

do not offer JS if v2 selected - #75

Closed
samualtnorman wants to merge 1 commit into
solidjs-community:mainfrom
samualtnorman:no-v2-js
Closed

do not offer JS if v2 selected#75
samualtnorman wants to merge 1 commit into
solidjs-community:mainfrom
samualtnorman:no-v2-js

Conversation

@samualtnorman

Copy link
Copy Markdown

this is a stopgap for #73

@ryansolid

Copy link
Copy Markdown
Contributor

Thanks for the stopgap @samualtnorman! Following up: the underlying issue #73 no longer reproduces on current main — the TS→JS conversion path was rewritten in #82 (sucrase-based), and JS output for the v2 templates now works end to end. I scaffolded the with-tailwindcss v2 template with JavaScript and vite dev boots and serves SSR HTML with no entry-server.tsx resolution error (details in #73 (comment), where I've closed the issue as fixed).

So suppressing the "Use Typescript?" prompt for v2 is no longer needed — JS is a valid choice for those templates again. Recommend closing this PR; leaving that to you since it's your branch. Thanks again for stepping in with the workaround while this was broken!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants